Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-70: Update install node dependencies task in the build #238

Merged

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Aug 23, 2024

  • removes test for installed dependencies, as Yarn already does that
  • removes call to install dependencies within Drupal core directory
  • removes option to resolve dependencies relative to Drupal core directory

This has a companion PR for drupal-skeleton, which adds the required dependencies to the project package.json. Tests passed on CircleCI, and the change to use that version of the skeleton was reverted: https://app.circleci.com/pipelines/github/palantirnet/the-build/589/workflows/fced6b6f-4a86-4e1a-8728-fd3610a1d741/jobs/600

See testing steps on the companion PR.

Copy link
Member

@becw becw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to this change. I made one suggestion by way of a commit (caching yarn packages on CircleCI).

@becw becw merged commit 52f2d18 into develop Aug 26, 2024
1 check passed
@becw becw deleted the DEV-70-update-install-node-dependencies-task-in-the-build branch August 26, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants